Hi Biju, On Wed, 2 Jul 2025 at 11:46, Biju Das <biju.das.jz@xxxxxxxxxxxxxx> wrote: > > From: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> > > On Sun, 29 Jun 2025 at 17:04, Biju Das <biju.das.jz@xxxxxxxxxxxxxx> wrote: > > > Drop unused macros from the rcar_canfd.c. > > > > > > Reported-by: Vincent Mailhol <mailhol.vincent@xxxxxxxxxx> > > > Closes: > > > https://lore.kernel.org/all/7ff93ff9-f578-4be2-bdc6-5b09eab64fe6@wanad > > > oo.fr/ > > > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx> > > #define RCANFD_RFPTR_RFDLC GENMASK(31, 28) > > > > > @@ -298,16 +256,10 @@ > > > #define RCANFD_GSTS (0x008c) > > > /* RSCFDnCFDGERFL / RSCFDnGERFL */ > > > #define RCANFD_GERFL (0x0090) > > > -/* RSCFDnCFDGTSC / RSCFDnGTSC */ > > > -#define RCANFD_GTSC (0x0094) > > > > Note that removed register offsets will become anonymous gaps when the register offsets are replaced > > by C structs, cfr. commit ab2aa5453bb83d05 > > ("can: rcar_canfd: Describe channel-specific FD registers using C struct"). > > OK. But removing unused reg offset is not an issue at the moment, I guess?? No, it is not an issue at the moment, as they are unused. Re-adding register members to a C struct later is just more tedious, as you have remove gaps or adjust their sizes (lol, mind the gap ;-). IIRC Vincent's biggest gripe is the use of function-like macros, not the definition of unused register offsets and bits? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
