Re: [PATCH v4 4/4] arm64: dts: renesas: rzg3e-smarc-som: Enable eth{0-1} (GBETH) interfaces

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi John,

On Wed, 2 Jul 2025 at 02:57, John Madieu <john.madieu.xa@xxxxxxxxxxxxxx> wrote:
> Enable the Gigabit Ethernet Interfaces (GBETH) populated on the RZ/G3E SMARC EVK
>
> Signed-off-by: John Madieu <john.madieu.xa@xxxxxxxxxxxxxx>

> v4:
>  - Update pinmux to add OEN support
>  - Drops Tb and Rb tags initially collected

Thanks for the update!

> --- a/arch/arm64/boot/dts/renesas/rzg3e-smarc-som.dtsi
> +++ b/arch/arm64/boot/dts/renesas/rzg3e-smarc-som.dtsi
>  &pinctrl {
> +       eth0_pins: eth0 {
> +               clk0 {

No need for the 0 ...

> +                       pinmux = <RZG3E_PORT_PINMUX(B, 1, 1)>; /* TXC */
> +                       output-enable;
> +               };
> +
> +               ctrl0 {

... suffixes...

> +       eth1_pins: eth1 {
> +               clk1 {

... or the 1...

> +                       pinmux = <RZG3E_PORT_PINMUX(E, 1, 1)>; /* TXC */
> +                       output-enable;
> +               };
> +
> +               ctrl1 {

... suffixes.


Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
i.e. will queue in renesas-devel for v6.17 with the above fixed.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds




[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux