Hi Prabhakar, On Fri, 27 Jun 2025 at 22:42, Prabhakar <prabhakar.csengg@xxxxxxxxx> wrote: > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> > > Add support for fixed-factor module clocks that can report their enable > status through the module status monitor. Introduce a new clock type, > CLK_TYPE_FF_MOD_STATUS, and define the associated structure, > rzv2h_ff_mod_status_clk, to manage these clocks. > > Implement the .is_enabled callback by reading the module status register > using monitor index and bit definitions. Provide a helper macro, > DEF_FIXED_MOD_STATUS, to simplify the definition of such clocks. > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> Thanks for the update! > Note, this patch generates below checkpatch warning but this is > not a problem. > `WARNING: struct clk_ops should normally be const` This is indeed a false positive. > v1->v2: > - Moved rzv2h_clk_ff_mod_status_ops to the CPG private data structure > and initialized it in the CPG probe function. Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> i.e. will queue in renesas-clk for v6.17. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds