Re: [PATCH 2/2] pmdomain: renesas: sort Renesas Kconfig configs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Morimoto-san,

On Mon, 30 Jun 2025 at 01:18, Kuninori Morimoto
<kuninori.morimoto.gx@xxxxxxxxxxx> wrote:
> Renesas Kconfig is using "SoC serial number" for CONFIG symbol, but is
> using "SoC chip name" for menu description. Because of it, it looks
> random order when we run "make menuconfig".
>
> commit 6d5aded8d57f ("soc: renesas: Sort driver description title")
> sorted Renesas Kconfig is by menu description title order, but it makes
> confusable to add new config.
>
> Let's unify "System Controller support for ${CHIP_NUMBER} (${CHIP_NAME}).
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx>

Thanks for your patch!

> --- a/drivers/pmdomain/renesas/Kconfig
> +++ b/drivers/pmdomain/renesas/Kconfig
> @@ -2,114 +2,116 @@
>  if SOC_RENESAS
>  menu "Renesas PM Domains"
>
> +# SoC Type

"# Family"?

>  config SYSC_RCAR
>         bool "System Controller support for R-Car" if COMPILE_TEST
>
>  config SYSC_RCAR_GEN4
>         bool "System Controller support for R-Car Gen4" if COMPILE_TEST
>
> -config SYSC_R8A77995
> -       bool "System Controller support for R-Car D3" if COMPILE_TEST
> +config SYSC_RMOBILE
> +       bool "System Controller support for R-Mobile" if COMPILE_TEST
> +
> +# SoC
> +config SYSC_R8A7742
> +       bool "System Controller support for R8A7742 (RZ/G1H)" if COMPILE_TEST
>         select SYSC_RCAR

[...]

> -config SYSC_R8A779F0
> -       bool "System Controller support for R-Car S4-8" if COMPILE_TEST
> -       select SYSC_RCAR_GEN4
> +config SYSC_R8A7791
> +       bool "System Controller support for R8A7791 (R-Car M2-W/N)" if COMPILE_TEST

"R8A7791/R8A7793"?

> +       select SYSC_RCAR
>

The rest LGTM, so
Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds




[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux