Re: [PATCH 2/5] arm64: dts: renesas: sparrow-hawk: Add overlay for IMX219 on J1

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Marek,

Thanks for your feedback.

On 2025-06-29 15:40:52 +0200, Marek Vasut wrote:
> On 6/28/25 11:53 PM, Niklas Söderlund wrote:
> 
> Hello Niklas,
> 
> > +&{/} {
> > +	clk_cam_j1: clk_cam_j1 {
> > +		compatible = "fixed-clock";
> > +		#clock-cells = <0>;
> > +		clock-frequency = <24000000>;
> > +		status = "okay";
> > +	};
> > +
> > +	/* Page 29 / CSI_IF_CN / J1 */
> > +	reg_cam_j1: reg_cam_j1 {
> > +		compatible = "regulator-fixed";
> > +		regulator-name = "reg_cam_j1";
> > +		enable-active-high;
> > +		status = "okay";
> > +		gpios = <&gpio0 1 GPIO_ACTIVE_HIGH>;
> > +	};
> > +
> > +	reg_cam_j1_dummy: reg_cam_j1_dummy {
> > +		compatible = "regulator-fixed";
> > +		regulator-name = "reg_cam_j1_dummy";
> > +		status = "okay";
> 
> Is the 'status = "okay"' property needed for these regulators ? I think
> 'status = "okay"' is the default behavior if "status" property is not
> present , so 'status = "okay"' is superfluous here.

Indeed you are correct, the status property for the fixed regulators are 
superfluous. Will drop in next version, thanks for teaching me something 
new.

-- 
Kind Regards,
Niklas Söderlund




[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux