Hi Marek,
Thanks for your patch.
On 2025-06-25 11:59:59 +0200, Marek Vasut wrote:
> Add default trimming values for the four temperature sensors located
> in Renesas R-Car V4H Working Sample SoC. The trimming values are
> identical for all four THS temperature sensors.
>
> Signed-off-by: Marek Vasut <marek.vasut+renesas@xxxxxxxxxxx>
> ---
> Cc: "Niklas Söderlund" <niklas.soderlund@xxxxxxxxxxxx>
> Cc: "Rafael J. Wysocki" <rafael@xxxxxxxxxx>
> Cc: Daniel Lezcano <daniel.lezcano@xxxxxxxxxx>
> Cc: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> Cc: Lukasz Luba <lukasz.luba@xxxxxxx>
> Cc: Magnus Damm <magnus.damm@xxxxxxxxx>
> Cc: Zhang Rui <rui.zhang@xxxxxxxxx>
> Cc: linux-pm@xxxxxxxxxxxxxxx
> Cc: linux-renesas-soc@xxxxxxxxxxxxxxx
> ---
> drivers/thermal/renesas/rcar_gen3_thermal.c | 21 ++++++++++++++++++++-
> 1 file changed, 20 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/thermal/renesas/rcar_gen3_thermal.c b/drivers/thermal/renesas/rcar_gen3_thermal.c
> index a388bd3135e4..f361991e9651 100644
> --- a/drivers/thermal/renesas/rcar_gen3_thermal.c
> +++ b/drivers/thermal/renesas/rcar_gen3_thermal.c
> @@ -372,6 +372,17 @@ static const struct rcar_gen3_thermal_fuse_default_info
> },
> };
>
> +static const struct rcar_gen3_thermal_fuse_default_info
> + rcar_gen3_thermal_fuse_default_info_v4h = {
This could fit on one line (even without the symbol rename suggested in
1/2).
> + .ptat = { 3274, 2164, 985 },
> + .thcodes = { /* All four THS units share the same trimming */
> + { 3218, 2617, 1980 },
> + { 3218, 2617, 1980 },
> + { 3218, 2617, 1980 },
> + { 3218, 2617, 1980 },
> + }
> +};
> +
I can't review the values themself, but testing on V4H the readout looks
good! With the line length nit-pick comment above fixed,
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx>
> static const struct rcar_thermal_info rcar_m3w_thermal_info = {
> .scale = 157,
> .adj_below = -41,
> @@ -396,6 +407,14 @@ static const struct rcar_thermal_info rcar_gen4_thermal_info = {
> .fuse_defaults = &rcar_gen3_thermal_fuse_default_info_gen3,
> };
>
> +static const struct rcar_thermal_info rcar_v4h_thermal_info = {
> + .scale = 167,
> + .adj_below = -41,
> + .adj_above = 126,
> + .fuses = &rcar_gen3_thermal_fuse_info_gen4,
> + .fuse_defaults = &rcar_gen3_thermal_fuse_default_info_v4h,
> +};
> +
> static const struct of_device_id rcar_gen3_thermal_dt_ids[] = {
> {
> .compatible = "renesas,r8a774a1-thermal",
> @@ -439,7 +458,7 @@ static const struct of_device_id rcar_gen3_thermal_dt_ids[] = {
> },
> {
> .compatible = "renesas,r8a779g0-thermal",
> - .data = &rcar_gen4_thermal_info,
> + .data = &rcar_v4h_thermal_info,
> },
> {
> .compatible = "renesas,r8a779h0-thermal",
> --
> 2.47.2
>
--
Kind Regards,
Niklas Söderlund
