Hi Dan, On Tue, 24 Jun 2025 at 16:17, Dan Scally <dan.scally@xxxxxxxxxxxxxxxx> wrote: > On 24/06/2025 14:16, Krzysztof Kozlowski wrote: > > On 24/06/2025 14:35, Daniel Scally wrote: > >> The RZ/V2H SoC has a block called the Input Video Control block which > >> feeds image data into the Image Signal Processor. Add dt bindings to > >> describe the IVC. > >> > >> Signed-off-by: Daniel Scally <dan.scally@xxxxxxxxxxxxxxxx> > >> --- > >> Changes in v2: > >> > >> - compatible matches filename > > This is not what I asked. > > Ah, you meant the other way round. Ok. > > > > >> - Added power-domains > >> - Aligned clock and reset entries on opening "<" > >> - Removed status = "okay"; from example > >> --- > >> .../bindings/media/renesas,rzv2h-ivc.yaml | 103 +++++++++++++++++++++ > >> 1 file changed, 103 insertions(+) > >> > >> diff --git a/Documentation/devicetree/bindings/media/renesas,rzv2h-ivc.yaml b/Documentation/devicetree/bindings/media/renesas,rzv2h-ivc.yaml > >> new file mode 100644 > >> index 0000000000000000000000000000000000000000..ee0849eeeaba840cf43c81d69449c631ad1c6a6a > >> --- /dev/null > >> +++ b/Documentation/devicetree/bindings/media/renesas,rzv2h-ivc.yaml > >> @@ -0,0 +1,103 @@ > >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > >> +%YAML 1.2 > >> +--- > >> +$id: http://devicetree.org/schemas/media/renesas,rzv2h-ivc.yaml# > >> +$schema: http://devicetree.org/meta-schemas/core.yaml# > >> + > >> +title: Renesas RZ/V2H Input Video Control Block > >> + > >> +maintainers: > >> + - Daniel Scally <dan.scally@xxxxxxxxxxxxxxxx> > >> + > >> +description: > >> + The IVC block is a module that takes video frames from memory and feeds them > >> + to the Image Signal Processor for processing. > >> + > >> +properties: > >> + compatible: > >> + const: renesas,rzv2h-ivc > > No, you cannot use generic compatibles. See writing bindings (or > > basically every review from DT maintainers). > > > OK...to throw a spanner into this, I think there's actually two soc codes with the IP; r9a09g057h44 > and r9a09g057h48. renesas,rzg2l-cru.yaml and renesas,rzg2l-csi2.yaml seem to use the 'generic' code > in a way that suggests this: Do you need to distinguish between r9a09g057h44 and r9a09g057h48 for the IVC block? Isn't renesas,r9a09g057-ivc good enough? https://elixir.bootlin.com/linux/v6.15.3/source/Documentation/devicetree/bindings/soc/renesas/renesas.yaml#L554 Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
