Hi Wolfram,
On Wed, 11 Jun 2025 at 11:39, Wolfram Sang
<wsa+renesas@xxxxxxxxxxxxxxxxxxxx> wrote:
> Clocks extracted from the BSP driver and rebased. Power domain handling
> added by Claudiu.
>
> Co-developed-by: Claudiu Beznea <claudiu.beznea.uj@xxxxxxxxxxxxxx>
> Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@xxxxxxxxxxxxxx>
> Signed-off-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>
Thanks for your patch!
> --- a/drivers/clk/renesas/r9a08g045-cpg.c
> +++ b/drivers/clk/renesas/r9a08g045-cpg.c
> @@ -243,6 +244,8 @@ static const struct rzg2l_mod_clk r9a08g045_mod_clks[] = {
> DEF_MOD("adc_adclk", R9A08G045_ADC_ADCLK, R9A08G045_CLK_TSU, 0x5a8, 0),
> DEF_MOD("adc_pclk", R9A08G045_ADC_PCLK, R9A08G045_CLK_TSU, 0x5a8, 1),
> DEF_MOD("tsu_pclk", R9A08G045_TSU_PCLK, R9A08G045_CLK_TSU, 0x5ac, 0),
> + DEF_MOD("i3c_pclk", R9A08G045_I3C_PCLK, R9A08G045_CLK_TSU, 0x610, 0),
> + DEF_MOD("i3c_tclk", R9A08G045_I3C_TCLK, R9A08G045_CLK_P5, 0x610, 1),
> DEF_MOD("vbat_bclk", R9A08G045_VBAT_BCLK, R9A08G045_OSCCLK, 0x614, 0),
> };
>
> @@ -358,6 +363,8 @@ static const struct rzg2l_cpg_pm_domain_init_data r9a08g045_pm_domains[] = {
> DEF_REG_CONF(CPG_BUS_MCPU2_MSTOP, BIT(14)), 0),
> DEF_PD("tsu", R9A08G045_PD_TSU,
> DEF_REG_CONF(CPG_BUS_MCPU2_MSTOP, BIT(15)), 0),
> + DEF_PD("i3c", R9A08G045_PD_I3C,
> + DEF_REG_CONF(CPG_BUS_MCPU3_MSTOP, BIT(10)), 0),
> DEF_PD("vbat", R9A08G045_PD_VBAT,
> DEF_REG_CONF(CPG_BUS_MCPU3_MSTOP, BIT(8)),
> GENPD_FLAG_ALWAYS_ON),
r9a08g045_pm_domains[] is gone.
Please add "MSTOP(BUS_MCPU3, BIT(10))" to the "DEF_MOD("i3c_pclk", ...)"
and "DEF_MOD("i3c_tclk", ...)" entries above instead.
The rest LGTM.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
