On Wed, Jun 18, 2025 at 09:44:02AM +0200, Geert Uytterhoeven wrote: > Hi Laurent, > > On Tue, 17 Jun 2025 at 21:48, Laurent Pinchart > <laurent.pinchart@xxxxxxxxxxxxxxxx> wrote: > > On Fri, Jun 06, 2025 at 08:26:01PM +0200, Niklas Söderlund wrote: > > > The VIN usage of v4l-async is complex and stems from organic growth of > > > the driver of supporting both private local subdevices (Gen2, Gen3) and > > > subdevices shared between all VIN instances (Gen3 and Gen4). > > > > > > The driver used a separate notifier for each VIN for the private local > > > ones, and a shared group notifier for the shared ones. This was complex > > > and lead to subtle bugs when unbinding and later rebinding subdevices in > > > one of the notifiers having to handle different edge cases depending on > > > if it also had subdevices in the other notifiers etc. > > > > > > To simplify this have the Gen2 devices allocate and form a VIN group > > > too. This way all subdevices on all models can be collect in a > > > single group notifier. Then there is only a single complete callback for > > > all where the video devices and subdevice nodes can be registered etc. > > > > > > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx> > > > Tested-by: Tomi Valkeinen <tomi.valkeinen+renesas@xxxxxxxxxxxxxxxx> > > [ deleted 132 lines of quoted patch ] > > > > @@ -417,6 +452,12 @@ static int rvin_group_notifier_init(struct rvin_dev *vin, unsigned int port, > > > if (!(vin_mask & BIT(i))) > > > continue; > > > > > > + /* Parse local subdevice. */ > > > + ret = rvin_parallel_parse_of(vin->group->vin[i]); > > > + if (ret) > > > + return ret; > > > + > > > + /* Prase shared subdevices. */ > > > > s/Prase/Parse/ > > > > Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx> > > Thanks, but please trim your replies, I had to scroll three times > through your email to find this ;-) I intentionally don't, as I find it annoying when people do :-) > [ deleted 262 lines of quoted patch ] -- Regards, Laurent Pinchart
