Re: [PATCH v2 2/3] dt-bindings: pwm: argon40,fan-hat: Document Argon40 Fan HAT

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Marek,

On Tue, Jun 17, 2025 at 02:28:01AM +0200, Marek Vasut wrote:
> Document trivial PWM on Argon40 Fan HAT, which is a RaspberryPi
> blower fan hat which can be controlled over I2C.
> 
> Signed-off-by: Marek Vasut <marek.vasut+renesas@xxxxxxxxxxx>
> ---
> Cc: "Uwe Kleine-König" <ukleinek@xxxxxxxxxx>
> Cc: Conor Dooley <conor+dt@xxxxxxxxxx>
> Cc: Krzysztof Kozlowski <krzk+dt@xxxxxxxxxx>
> Cc: Rob Herring <robh@xxxxxxxxxx>
> Cc: devicetree@xxxxxxxxxxxxxxx
> Cc: linux-pwm@xxxxxxxxxxxxxxx
> Cc: linux-renesas-soc@xxxxxxxxxxxxxxx
> ---
> V2: Implement dedicated binding document
> ---
>  .../bindings/pwm/argon40,fan-hat.yaml         | 47 +++++++++++++++++++
>  1 file changed, 47 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/pwm/argon40,fan-hat.yaml
> 
> diff --git a/Documentation/devicetree/bindings/pwm/argon40,fan-hat.yaml b/Documentation/devicetree/bindings/pwm/argon40,fan-hat.yaml
> new file mode 100644
> index 000000000000..2725eee5328c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/pwm/argon40,fan-hat.yaml
> @@ -0,0 +1,47 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/pwm/argon40,fan-hat.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Argon40 Fan HAT PWM controller
> +
> +maintainers:
> +  - Marek Vasut <marek.vasut+renesas@xxxxxxxxxxx>
> +
> +description: |
> +  The trivial PWM on Argon40 Fan HAT, which is a RaspberryPi blower fan
> +  hat which can be controlled over I2C, generates a fixed duty cycle PWM
> +  signal with configurable period to control the fan speed.

Did you get that right? I would have expected a fixed period and the
parameter modifying the duty cycle?

> +allOf:
> +  - $ref: pwm.yaml#
> +
> +properties:
> +  compatible:
> +    const: argon40,fan-hat
> +
> +  reg:
> +    maxItems: 1
> +
> +  "#pwm-cells":
> +    const: 2

const: 3

Best regards
Uwe

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux