Hi Geert, Thank you for the review. On Thu, Jun 12, 2025 at 1:17 PM Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote: > > Hi Prabhakar, > > On Mon, 9 Jun 2025 at 20:41, Prabhakar <prabhakar.csengg@xxxxxxxxx> wrote: > > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> > > > > Document support for the I2C Bus Interface (RIIC) found on the Renesas > > RZ/T2H (R9A09G077) SoC. The RIIC IP on this SoC is similar to that on > > the RZ/V2H(P) SoC but supports fewer interrupts, lacks FM+ support and > > does not require resets. Due to these differences, add a new compatible > > string `renesas,riic-r9a09g077` for the RZ/T2H SoC. > > > > Unlike earlier SoCs that use eight distinct interrupts, the RZ/T2H uses > > only four, including a combined error/event interrupt. Update the binding > > schema to reflect this interrupt layout and skip the `resets` property > > check, as it is not required on these SoCs. > > > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> > > Acked-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx> > > Reviewed-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx> > > --- > > v1-> v2: > > - Listed the interrupts in the order as mentioned in the > > HW manual. > > - Renamed the interrupt names to match the HW manual. > > - Added Acked-by and Reviewed-by tags. > > Thanks for the update! > > > --- a/Documentation/devicetree/bindings/i2c/renesas,riic.yaml > > +++ b/Documentation/devicetree/bindings/i2c/renesas,riic.yaml > > @@ -29,32 +29,46 @@ properties: > > - renesas,riic-r9a09g056 # RZ/V2N > > - const: renesas,riic-r9a09g057 # RZ/V2H(P) > > > > - - const: renesas,riic-r9a09g057 # RZ/V2H(P) > > + - enum: > > + - renesas,riic-r9a09g057 # RZ/V2H(P) > > + - renesas,riic-r9a09g077 # RZ/T2H > > > > reg: > > maxItems: 1 > > > > interrupts: > > - items: > > - - description: Transmit End Interrupt > > - - description: Receive Data Full Interrupt > > - - description: Transmit Data Empty Interrupt > > - - description: Stop Condition Detection Interrupt > > - - description: Start Condition Detection Interrupt > > - - description: NACK Reception Interrupt > > - - description: Arbitration-Lost Interrupt > > - - description: Timeout Interrupt > > + oneOf: > > + - items: > > + - description: Transmit End Interrupt > > + - description: Receive Data Full Interrupt > > + - description: Transmit Data Empty Interrupt > > + - description: Stop Condition Detection Interrupt > > + - description: Start Condition Detection Interrupt > > + - description: NACK Reception Interrupt > > + - description: Arbitration-Lost Interrupt > > + - description: Timeout Interrupt > > + - items: > > + - description: Transmit Error Or Event Generation > > s/Transmit/Transfer/ > Agreed. > > + - description: Receive Data Full Interrupt > > + - description: Transmit End Interrupt > > + - description: Transmit Data Empty Interrupt > > The last two don't match the order in the documentation, and the > order in interrupt-names below. > Ouch, I'll fix that and send a new version. Cheers, Prabhakar
