Hi Mingyin, On Tue, 10 Jun 2025 at 13:34, <shao.mingyin@xxxxxxxxxx> wrote: > From: Shao Mingyin <shao.mingyin@xxxxxxxxxx> > > Replace ternary (condition ? "enable" : "disable") syntax and ternary > (condition ? "on" : "off") syntax with helpers from > string_choices.h because: > 1. Simple function call with one argument is easier to read. Ternary > operator has three arguments and with wrapping might lead to quite > long code. > 2. Is slightly shorter thus also easier to read. > 3. It brings uniformity in the text - same string. > 4. Allows deduping by the linker, which results in a smaller binary > file. > > Signed-off-by: Shao Mingyin <shao.mingyin@xxxxxxxxxx> > --- > v2: > %sable ==> %s in jh71xx_pmu_dev() Thanks for the update! While I already provided my Rb-tag on Krzysztof's original [1], your version is whitespace-damaged (TABs replaced by spaces), and thus cannot be applied. [1] https://lore.kernel.org/all/CAMuHMdXJ57mATWW4AnBedn+D7TQ4PadkJ642daquFtAo=wZFrQ@xxxxxxxxxxxxxx/ Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
