Hi Geert,
Thank you for the review.
On Thu, Jun 12, 2025 at 1:49 PM Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:
>
> Hi Prabhakar,
>
> On Wed, 28 May 2025 at 16:05, Prabhakar <prabhakar.csengg@xxxxxxxxx> wrote:
> > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
> >
> > Enable USB2.0 support on the RZ/V2N EVK board, CN2 connector on the EVK
> > supports host/function operation.
> >
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
>
> Thanks for your patch!
>
> > --- a/arch/arm64/boot/dts/renesas/r9a09g056n48-rzv2n-evk.dts
> > +++ b/arch/arm64/boot/dts/renesas/r9a09g056n48-rzv2n-evk.dts
> > @@ -302,6 +317,16 @@ sd1-dat-cmd {
> > slew-rate = <0>;
> > };
> > };
> > +
> > + usb20_pins: usb20 {
> > + ovc {
> > + pinmux = <RZV2N_PORT_PINMUX(9, 6, 14)>; /* OVC */
>
> Any specific reason why OVC needs "bias-pull-up" on RZ/V2H EVK, but
> not on RZ/V2N EVK?
>
On the RZ/V2N EVK for the USB20_OVRCUR pin we have R13110K0603 pullup
resistor, this was missing on the earlier version of the RZ/V2H EVK
due to which we saw false OC condition (as seen below). Said that the
actual EVKs for RZ/V2H for which support is being added do have this
pullup resistor. After testing I will post a patch to drop the
`bias-pull-up` property from the RZ/V2H DTS (thanks for reminding me
:-)).
[ 2.672424] usb usb3-port1: over-current condition
[ 2.792424] usb usb4-port1: over-current condition
Cheers,
Prabhakar
