Re: [PATCH 2/9] can: rcar_canfd: Use ndev parameter in rcar_canfd_set_bittiming()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Vincent,

On Mon, 2 Jun 2025 at 15:01, Vincent Mailhol <mailhol.vincent@xxxxxxxxxx> wrote:
> On 02/06/2025 at 20:54, Geert Uytterhoeven wrote:
> > There is no need to do a back-and-forth "priv = netdev_priv(ndev)" and
> > "priv->ndev" where the "ndev" parameter is available.
> >
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
>
> Are these still useful anyhow? You can get all the bittiming values through the
> netlink interface.

My first thought was "They are useful, when you are stuck with an
old initrd that only has an old ifconfig", but then I realized you
need a fairly recent iproute2 package anyway.

> Well, if you tell me these are still useful, then I trust you and OK to keep. If
> not, consider removing.

No, I will remove them.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds




[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux