On 02/06/2025 at 20:54, Geert Uytterhoeven wrote: > Hi all, > > This patch series adds CAN-FD Transceiver Delay Compensation support to > the R-Car CAN-FD driver, after the customary cleanups and refactorings. > > This has been tested on R-Car V4H (White Hawk), V4M (Gray Hawk Single), > and E3 (Ebisu-4D[1]), using various data bit rates. Without proper TDC > configuration, transmitting at 8 Mbps makes the CAN-FD controller enter > BUS-OFF state. The TDCV value as measured by the CAN-FD controller is 4 > on all boards tested (base clock 40 MHz, i.e. 25 ns period), and ca. 90 > ns as measured by a logic analyzer on Gray Hawk Single. > > Note that the BSP (predating upstream TDC support), uses a much simpler > method: for transfer rates >= 5 Mbps on R-Car Gen4, it enables TDC with > a hardcoded (hardware) TDCO value of 2 (i.e. actual 3), which matches > the behavior of this series at 8 Mbps. > > Thanks for your comments! Aside from my request to change the function like macros into actual functions, the series looks good. Under the condition that you rework the macros into functions: Reviewed-by: Vincent Mailhol <mailhol.vincent@xxxxxxxxxx> Yours sincerely, Vincent Mailhol
