Hi Tomi,
Thank you for the patch.
On Fri, May 30, 2025 at 04:50:33PM +0300, Tomi Valkeinen wrote:
> With multiple streams the operation to enable the CSI-2 hardware and to
> call {enable|disable}_streams() on upstream subdev will need to be
> handled separately.
>
> Prepare for that by moving {enable|disable}_streams() calls out from
> rcsi2_start() and rcsi2_stop().
Same comments as for 03/15. Maybe this will become clearer in subsequent
patches, but the change should then probably be squashed in those
patches.
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen+renesas@xxxxxxxxxxxxxxxx>
> ---
> drivers/media/platform/renesas/rcar-csi2.c | 17 +++++++++--------
> 1 file changed, 9 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/media/platform/renesas/rcar-csi2.c b/drivers/media/platform/renesas/rcar-csi2.c
> index ddbdde23c122..698eb0e60f32 100644
> --- a/drivers/media/platform/renesas/rcar-csi2.c
> +++ b/drivers/media/platform/renesas/rcar-csi2.c
> @@ -1573,20 +1573,12 @@ static int rcsi2_start(struct rcar_csi2 *priv, struct v4l2_subdev_state *state)
> return ret;
> }
>
> - ret = v4l2_subdev_enable_streams(priv->remote, priv->remote_pad,
> - BIT_ULL(0));
> - if (ret) {
> - rcsi2_enter_standby(priv);
> - return ret;
> - }
> -
> return 0;
> }
>
> static void rcsi2_stop(struct rcar_csi2 *priv)
> {
> rcsi2_enter_standby(priv);
> - v4l2_subdev_disable_streams(priv->remote, priv->remote_pad, BIT_ULL(0));
> }
>
> static int rcsi2_enable_streams(struct v4l2_subdev *sd,
> @@ -1608,6 +1600,13 @@ static int rcsi2_enable_streams(struct v4l2_subdev *sd,
> return ret;
> }
>
> + ret = v4l2_subdev_enable_streams(priv->remote, priv->remote_pad,
> + BIT_ULL(0));
> + if (ret) {
> + rcsi2_stop(priv);
> + return ret;
> + }
> +
> priv->stream_count += 1;
>
> return ret;
> @@ -1629,6 +1628,8 @@ static int rcsi2_disable_streams(struct v4l2_subdev *sd,
> if (priv->stream_count == 1)
> rcsi2_stop(priv);
>
> + v4l2_subdev_disable_streams(priv->remote, priv->remote_pad, BIT_ULL(0));
> +
> priv->stream_count -= 1;
>
> return ret;
--
Regards,
Laurent Pinchart
