Hi Geert,
Thank you for the review.
On Mon, May 26, 2025 at 6:03 PM Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:
>
> Hi Thierry,
>
> On Mon, 19 May 2025 at 23:57, Thierry Bultel
> <thierry.bultel.yh@xxxxxxxxxxxxxx> wrote:
> > Document RZ/T2H (a.k.a r9a09g077) pinctrl
> >
> > Signed-off-by: Thierry Bultel <thierry.bultel.yh@xxxxxxxxxxxxxx>
>
> Thanks for your patch!
>
> > --- a/Documentation/devicetree/bindings/pinctrl/renesas,pfc.yaml
> > +++ b/Documentation/devicetree/bindings/pinctrl/renesas,pfc.yaml
> > @@ -29,6 +29,7 @@ properties:
> > - renesas,pfc-r8a774b1 # RZ/G2N
> > - renesas,pfc-r8a774c0 # RZ/G2E
> > - renesas,pfc-r8a774e1 # RZ/G2H
> > + - renesas,pfc-r9a09g077 # RZ/T2H
> > - renesas,pfc-r8a7778 # R-Car M1
> > - renesas,pfc-r8a7779 # R-Car H1
> > - renesas,pfc-r8a7790 # R-Car H2
>
> From a quick glance at the docs and driver, adding support for RZ/T2H
> to this DT binding is a not good match, as the RZ/T2H PFC hardware
> does not have the concept of pin groups and functions.
>
> Using separate DT bindings, as for most other SoCs in the RZ family,
> also allows you to use the preferred order "renesas,r9a09g077-<foo>".
>
Agreed, this needs a separate DT binding file.
> > @@ -194,3 +209,13 @@ examples:
> > power-source = <3300>;
> > };
> > };
> > +
> > + - |
> > + pinctrl: pinctrl@812c0000 {
>
> The unit address does not match the first reg property.
>
> > + compatible = "renesas,pfc-r9a09g077";
> > + reg = <0x802c0000 0x2000>,
> > + <0x812c0000 0x2000>;
> > + gpio-controller;
> > + #gpio-cells = <2>;
> > + gpio-ranges = <&pinctrl 0 0 287>;
>
> GPIOs without interrupts?
>
I think the intention here was to go without interrupt support for the
initial series and when later support for ICU is added we add this
property. Hope thats OK?
Cheers,
Prabhakar
