On 30/05/2025 10:07, Geert Uytterhoeven wrote: > Hi Krzysztof, > > On Thu, 29 May 2025 at 08:41, Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote: >> On 29/05/2025 04:13, shao.mingyin@xxxxxxxxxx wrote: >>> From: Shao Mingyin <shao.mingyin@xxxxxxxxxx> >>> >>> Remove hard-coded strings by using the str_on_off() helper function. >>> >>> Signed-off-by: Shao Mingyin <shao.mingyin@xxxxxxxxxx> >>> --- >>> drivers/pmdomain/renesas/rcar-gen4-sysc.c | 3 ++- >>> drivers/pmdomain/renesas/rcar-sysc.c | 3 ++- >> >> Stop sending such trivial patches one driver per patch, but entire >> subsystem in one patch. That's a lot of churn, considering this was >> rejected: > > Was it? I only see my Rb, and a review comment asking for more... > >> https://lore.kernel.org/all/20250114203547.1013010-1-krzysztof.kozlowski@xxxxxxxxxx/ Indeed this one was not, but my other patchsets were - several subsystems clearly expressed that this is just a churn. So if doing this, because you do not consider it a churn, do it all at once to, not line by line. Best regards, Krzysztof
