On 28/05/2025 14:36, Geert Uytterhoeven wrote: > Hi Krzysztof, > > On Wed, 28 May 2025 at 12:41, Krzysztof Kozlowski > <krzysztof.kozlowski@xxxxxxxxxx> wrote: >> Always descent to drivers/pinctrl/starfive/ because limiting it with >> SOC_STARFIVE is redundant since all of its Kconfig entries are already > > ... since its Makefile doesn't build anything if no Starfive-specific > pin control Kconfig options are enabled? Yes, that's better. Thank you. > >> have "depends on SOC_STARFIVE". This allows compile testing on other >> architectures with allyesconfig. >> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> >> --- >> drivers/pinctrl/Makefile | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/pinctrl/Makefile b/drivers/pinctrl/Makefile >> index ac27e88677d14f1c697e0d0be9f295c746556f4d..dcede70b25660833a158c298d1269d6ecea9dd8b 100644 >> --- a/drivers/pinctrl/Makefile >> +++ b/drivers/pinctrl/Makefile >> @@ -82,7 +82,7 @@ obj-y += sophgo/ >> obj-y += spacemit/ >> obj-$(CONFIG_PINCTRL_SPEAR) += spear/ >> obj-y += sprd/ >> -obj-$(CONFIG_SOC_STARFIVE) += starfive/ >> +obj-y += starfive/ >> obj-$(CONFIG_PINCTRL_STM32) += stm32/ >> obj-y += sunplus/ >> obj-$(CONFIG_PINCTRL_SUNXI) += sunxi/ > > The actual change LGTM, so > Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> > Ack Best regards, Krzysztof
