Hi Niklas,
Thank you for the patch.
On Wed, May 21, 2025 at 03:20:32PM +0200, Niklas Söderlund wrote:
> When extending the driver with Gen4 support the iteration of over
> possible remote subdevices changed from being R-Car CSI-2 Rx only to
> also cover R-Car CSISP instances. In two loops updating the bounds
> variable was missed.
>
> This had no ill effect as the count the two values have always been the
> same in the past. Fix it before the two diverge.
>
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx>
> ---
> drivers/media/platform/renesas/rcar-vin/rcar-core.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/platform/renesas/rcar-vin/rcar-core.c b/drivers/media/platform/renesas/rcar-vin/rcar-core.c
> index 846ae7989b1d..b9ea5b8db559 100644
> --- a/drivers/media/platform/renesas/rcar-vin/rcar-core.c
> +++ b/drivers/media/platform/renesas/rcar-vin/rcar-core.c
> @@ -262,7 +262,7 @@ static void rvin_group_notify_unbind(struct v4l2_async_notifier *notifier,
>
> mutex_lock(&vin->group->lock);
>
> - for (i = 0; i < RVIN_CSI_MAX; i++) {
> + for (i = 0; i < RVIN_REMOTES_MAX; i++) {
Using ARRAY_SIZE would be even better I think.
for (i = 0; i < ARRAY_SIZE(vin->group->remotes); i++) {
Same below.
Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx>
> if (vin->group->remotes[i].asc != asc)
> continue;
> vin->group->remotes[i].subdev = NULL;
> @@ -284,7 +284,7 @@ static int rvin_group_notify_bound(struct v4l2_async_notifier *notifier,
>
> mutex_lock(&vin->group->lock);
>
> - for (i = 0; i < RVIN_CSI_MAX; i++) {
> + for (i = 0; i < RVIN_REMOTES_MAX; i++) {
> if (vin->group->remotes[i].asc != asc)
> continue;
> vin->group->remotes[i].subdev = subdev;
--
Regards,
Laurent Pinchart
