On Wed, Aug 20, 2025 at 01:08:41PM GMT, Jim Quinlan wrote: > On Tue, Aug 19, 2025 at 10:51 AM Manivannan Sadhasivam <mani@xxxxxxxxxx> wrote: > > > > On Thu, Jul 03, 2025 at 05:53:10PM GMT, Jim Quinlan wrote: > > > This series enables a new SoC to run with the existing Brcm STB PCIe > > > driver. Previous chips all required that an inbound window have a size > > > that is a power of two; this chip, and next generations chips like it, can > > > have windows of any reasonable size. > > > > > > Note: This series must follow the commits of two previous and pending > > > series [1,2]. > > > > > > [1] https://lore.kernel.org/linux-pci/20250613220843.698227-1-james.quinlan@xxxxxxxxxxxx/ > > > [2] https://lore.kernel.org/linux-pci/20250609221710.10315-1-james.quinlan@xxxxxxxxxxxx/ > > > > Have you considered my comment on this series? > > https://lore.kernel.org/linux-pci/a2ebnh3hmcbd5zr545cwu7bcbv6xbhvv7qnsjzovqbkar5apak@kviufeyk5ssr/ > > Hi Mani, > I'm sorry, I thought I replied to this but obviously I did not. > No issues! > Your points are valid. Our PCIe HW block keeps on mutating, and each > time it does we add new code that is triggered off of the soc_base > config setting. The end result is not easy on the eyes. > > I also have submitted the series "PCI: brcmstb: Include cable-modem > SoCs". I don't think it has review comments yet, but I am guessing > that you will make the same points. > Yes. I intentionally didn't give any comments or merge it since I have the same refactoring comments. > So it looks like what you are asking for is a refactoring of the > driver and, AFAICT, I need to first submit separate series that does > this before submitting the this and the cable modem submission. Do > you agree with that? > Yes, I agree. Refactoring will make life easier for both you and me :) - Mani -- மணிவண்ணன் சதாசிவம்
