On Thu, Aug 28, 2025 at 06:52:39AM +0800, Inochi Amaoto wrote: > On Wed, Aug 27, 2025 at 01:32:02PM -0500, Bjorn Helgaas wrote: > > On Wed, Aug 27, 2025 at 02:29:07PM +0800, Inochi Amaoto wrote: > > > For msi controller that only supports MSI_FLAG_PCI_MSI_MASK_PARENT, > > > the newly added callback irq_startup() and irq_shutdown() for > > > pci_msi[x]_templete will not unmask/mask the interrupt when startup/ > > > shutdown the interrupt. This will prevent the interrupt from being > > > enabled/disabled normally. > > > > s/templete/template/ > > > AFAICS cond_startup_parent() is used by pci_irq_startup_msi() and > > pci_irq_startup_msix() in pci_msi_template; cond_shutdown_parent() is > > used by pci_irq_shutdown_msi() and pci_irq_shutdown_msix() in > > pci_msix_template. > > cond_startup_parent() is used by pci_irq_startup_msi() in > pci_msi_template and pci_irq_startup_msix() in pci_msix_template; > cond_shutdown_parent() is used by pci_irq_shutdown_msi() in > pci_msi_template and pci_irq_shutdown_msix() in pci_msix_template. Right, I really screwed that up when I noticed the "*_template" structure names and added them to my description.
