Hi Rob,
Thank you for your reply.
> > +
> > +examples:
> > + - |
> > + #include <dt-bindings/interrupt-controller/arm-gic.h>
> > + #include <dt-bindings/clock/ast2600-clock.h>
> > +
> > + apb {
> > + #address-cells = <1>;
> > + #size-cells = <1>;
>
> No need to show this node.
>
Agreed.
I will remove the apb node in next version.
> > +
> > + pcie0: pcie@1e770000 {
> > + compatible = "aspeed,ast2600-pcie";
> > + device_type = "pci";
> > + reg = <0x1e770000 0x100>;
> > + linux,pci-domain = <0>;
> > + #address-cells = <3>;
> > + #size-cells = <2>;
> > + interrupts = <GIC_SPI 168 IRQ_TYPE_LEVEL_HIGH>;
> > + bus-range = <0x80 0xff>;
> > +
> > + ranges = <0x01000000 0x0 0x00018000 0x00018000 0x0
> 0x00008000
> > + 0x02000000 0x0 0x70000000 0x70000000 0x0 0x10000000>;
> > +
> > + status = "disabled";
>
> Examples should be enabled. Drop.
>
Agreed.
I will remove it in next version.
> > +
> > + resets = <&syscon ASPEED_RESET_H2X>;
> > + reset-names = "h2x";
> > +
> > + #interrupt-cells = <1>;
> > + msi-parent = <&pcie0>;
>
> There shouldn't be any need to point to yourself.
>
Agreed.
Since this RC implements its own MSI controller, the self-referential msi-parent isn't needed.
I will remove it in next version.
Thanks,
Jacky
