Hello, > When endpoint controller driver is immature, the fields dma_chan_tx and > dma_chan_rx of the struct pci_epf_test could be NULL even after epf > initialization. However, pci_epf_test_clean_dma_chan() assumes that they > are always non-NULL valid values, and causes kernel panic when the Simply saying that the fields can be NULL, which can lead to a panic on access in some cases, and hence it's prudent to check for the non-NULL values, would be sufficient. Wording-wise, whether the driver is immature, mature, or middle-aged, it's completely irrelevant here. Otherwise, changes look good, as such: Reviewed-by: Krzysztof Wilczyński <kwilczynski@xxxxxxxxxx> Thank you, Krzysztof
