Re: [PATCH] PCI: endpoint: pci-epf-test: NULL check dma channels before release

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sep 12, 2025 / 22:28, Manivannan Sadhasivam wrote:
> On Fri, Sep 12, 2025 at 04:11:40PM GMT, Shin'ichiro Kawasaki wrote:
> > When endpoint controller driver is immature, the fields dma_chan_tx and
> > dma_chan_rx of the struct pci_epf_test could be NULL even after epf
> > initialization. However, pci_epf_test_clean_dma_chan() assumes that they
> > are always non-NULL valid values, and causes kernel panic when the
> > fields are NULL. To avoid the kernel panic, NULL check the fields before
> > release.
> > 
> 
> Have you seen the kernel panic or just predicting it by the code? If you have
> seen it, it is better to add the logs, Fixes tag and CC stable list. Even if
> not, Fixes tag would be needed since it is a bug fix.

I saw the panic. Will add the kernel message I observed to the commit message
as well as Fixes and CC stable tags. Thanks.




[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux