On 11/07/2025 10:26, Ziyue Zhang wrote: > > On 6/27/2025 3:08 PM, Krzysztof Kozlowski wrote: >> On Wed, Jun 25, 2025 at 05:00:46PM +0800, Ziyue Zhang wrote: >>> Each PCIe controller on sa8775p includes 'link_down'reset on hardware, >>> document it. >> This is an ABI break, so you need to clearly express it and explain the >> impact. Following previous Qualcomm feedback we cannot give review to >> imperfect commits, because this would be precedent to accept such >> imperfectness in the future. >> >> Therefore follow all standard rules about ABI. >> >> Best regards, >> Krzysztof > > Hi Krzysztof > > > This does not break the ABI. In the Qualcomm PCIe driver, we use the APIs > devm_reset_control_array_get_exclusive, reset_control_assert, and I see in the binding requirement of 1 reset before and after your patch: requirement of two reset lines. This is an ABI change. My entire comment stays valid, so don't just deflect it but resolve it. Best regards, Krzysztof
