On Fri, 4 Jul 2025 00:15:19 +0200 Danilo Krummrich <dakr@xxxxxxxxxx> wrote: > On 6/23/25 8:09 AM, FUJITA Tomonori wrote: >> Enable support for device ID structures that do not contain >> context/data field (usually named `driver_data`), making the trait >> usable in a wider range of subsystems and buses. >> Several such structures are defined in >> include/linux/mod_devicetable.h. >> This refactoring is a preparation for enabling the PHY abstractions to >> use device_id trait. >> Signed-off-by: FUJITA Tomonori <fujita.tomonori@xxxxxxxxx> > > Acked-by: Danilo Krummrich <dakr@xxxxxxxxxx> Thanks a lot! Miguel suggested that splitting the RawDeviceId trait might lead to a cleaner design, and I also tried that approach [v2]. But just to confirm ― do you prefer the original v1 approach instead? https://lore.kernel.org/lkml/CANiq72k0sdUoBxVYghgh50+ZRV2gbDkgVjuZgJLtj=4s9852xg@xxxxxxxxxxxxxx/ [v2]: https://lore.kernel.org/rust-for-linux/20250701141252.600113-1-fujita.tomonori@xxxxxxxxx/ Either way works for me. Sorry Miguel, I forgot to fix the comment typo you pointed out in v1. I'll correct it in v3.
