> > +description: |
> > + The ASPEED PCIe configuration syscon block provides a set of
> > +registers shared
>
> How is this a pci device? You just described syscon, so this goes to soc.
>
> All other comments apply as well.
Agreed.
It is not a device. I will move to soc.
>
> > + by multiple PCIe-related devices within the SoC. This node
> > + represents the common configuration space that allows these devices
> > + to coordinate and manage shared PCIe settings, including address
> > + mapping, control, and status registers. The syscon interface
> > + enables Linux drivers for various PCIe devices
>
> Do not describe OS. Describe the hardware and drop Linux drivers completely.
Agreed.
>
> > + to access and modify these shared registers in a consistent and
> > + centralized manner.
> > +
> > +properties:
> > + compatible:
> > + enum:
> > + - aspeed,ast2600-pcie-cfg
> > + - aspeed,ast2700-pcie-cfg
> > +
> > + reg:
> > + maxItems: 1
> > +
> > +required:
> > + - compatible
> > + - reg
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > + - |
> > + pcie-cfg@1e770000 {
>
> Node names should be generic. See also an explanation and list of examples
> (not exhaustive) in DT specification:
> https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-
> basics.html#generic-names-recommendation
>
> Look how syscons are called in other vendors.
Agreed.
Thanks,
Jacky
