> > Filename basedon compatible > > A nit, subject: drop second/last, redundant "document for". The "dt-bindings" > prefix is already stating that these are documents. > See also: > https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bin > dings/submitting-patches.rst#L18 Agreed. > > > MAINTAINERS | 10 +++++ > > 2 files changed, 48 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/phy/aspeed-pcie-phy.yaml > > > > diff --git > > a/Documentation/devicetree/bindings/phy/aspeed-pcie-phy.yaml > > b/Documentation/devicetree/bindings/phy/aspeed-pcie-phy.yaml > > new file mode 100644 > > index 000000000000..762bf7b0aedc > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/phy/aspeed-pcie-phy.yaml > > @@ -0,0 +1,38 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/phy/aspeed-pcie-phy.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: ASPEED PCIe PHY > > + > > +maintainers: > > + - Jacky Chou <jacky_chou@xxxxxxxxxxxxxx> > > + > > +description: | > > Do not need '|' unless you need to preserve formatting. Agreed. > > > + The ASPEED PCIe PHY provides the physical layer interface for PCIe > > + controllers in the SoC. This node represents the register block for > > + the PCIe PHY, which is typically accessed by PCIe Root Complex or > > + Endpoint drivers via syscon. > > + > > +properties: > > + compatible: > > + enum: > > + - aspeed,ast2600-pcie-phy > > + - aspeed,ast2700-pcie-phy > > + > > + reg: > > + maxItems: 1 > > + > > No phy cells? How is this a phy exactly? > > No resources? This looks just incomplete. There is no resource. I will add the following description in next version. "#phy-cells": const: 0 > > > +required: > > + - compatible > > + - reg > > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + pcie-phy@1e6ed200 { > > + compatible = "aspeed,ast2600-pcie-phy"; > > + reg = <0x1e6ed200 0x100>; > > + }; > > diff --git a/MAINTAINERS b/MAINTAINERS index > > a5a650812c16..68115443607d 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -3696,6 +3696,16 @@ S: Maintained > > F: > Documentation/devicetree/bindings/media/aspeed,video-engine.yaml > > F: drivers/media/platform/aspeed/ > > > > +ASPEED PCIE CONTROLLER DRIVER > > +M: Jacky Chou <jacky_chou@xxxxxxxxxxxxxx> > > +L: linux-aspeed@xxxxxxxxxxxxxxxx (moderated for non-subscribers) > > +L: linux-pci@xxxxxxxxxxxxxxx > > +S: Maintained > > +F: Documentation/devicetree/bindings/pci/aspeed-pcie-cfg.yaml > > +F: Documentation/devicetree/bindings/pci/aspeed-pcie.yaml > > +F: Documentation/devicetree/bindings/phy/aspeed-pcie-phy.yaml > > +F: drivers/pci/controller/pcie-aspeed.c > > There is no such file... actually many above do not exist. I will separate MAINTAINERS from this patch to a single patch attached the end of series in next version. Thanks, Jacky
