RE: [v3 PATCH 1/1] PCI: of: fix non-prefetchable region address range check.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> > +                     if (!(res->flags & IORESOURCE_PREFETCH))
> > +                             if (upper_32_bits(range.pci_addr + range.size - 1))
> > +                                     dev_warn(dev, "Memory resource
> > + size exceeds max for 32 bits\n");
> 
> Seems mostly right to me.  I think we should update the message to talk about
> the *address* instead of the size, since that's the real problem.  Also would be
> nice to include the resource (%pR) and the corresponding bus addresses as we
> do in pci_register_host_bridge().
> 

I agree. I will update the message and send out a new patch for review. Thanks for taking the time to have a look!

Kind regards

Wannes





[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux