Hi Niklas, I have replied to Bjorn. For the next version, I will send the patches of this series using the company's environment. Please look at this link. Could you please also help review it? Thank you very much. https://lore.kernel.org/linux-pci/c31c3834-247d-4a28-bd2c-4a39ea719625@xxxxxxx/ Best regards, Hans -----邮件原件----- 发件人: Niklas Cassel <cassel@xxxxxxxxxx> 发送时间: 2025年6月13日 20:03 收件人: Hans Zhang <18255117159@xxxxxxx> 抄送: lpieralisi@xxxxxxxxxx; bhelgaas@xxxxxxxxxx; mani@xxxxxxxxxx; kwilczynski@xxxxxxxxxx; robh@xxxxxxxxxx; jingoohan1@xxxxxxxxx; linux-pci@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx 主题: Re: [PATCH 01/13] PCI: dwc: Add dw_pcie_clear_and_set_dword() for register bit manipulation EXTERNAL EMAIL On Thu, Jun 12, 2025 at 12:30:57AM +0800, Hans Zhang wrote: > DesignWare PCIe controller drivers implement register bit manipulation > through explicit read-modify-write sequences. These patterns appear > repeatedly across multiple drivers with minor variations, creating > code duplication and maintenance overhead. > > Implement dw_pcie_clear_and_set_dword() helper to encapsulate atomic > register modification. The function reads the current register value, > clears specified bits, sets new bits, and writes back the result in a > single operation. This abstraction hides bitwise manipulation details > while ensuring consistent behavior across all usage sites. > > Centralizing this logic reduces future maintenance effort when > modifying register access patterns and minimizes the risk of > implementation divergence between drivers. > > Signed-off-by: Hans Zhang <18255117159@xxxxxxx> No cover-letter? Usually for things like this, it is nice to see the diffstat, which is usually part of the cover-letter. Kind regards, Niklas
