On Thu, Jun 12, 2025 at 12:30:57AM +0800, Hans Zhang wrote: > DesignWare PCIe controller drivers implement register bit manipulation > through explicit read-modify-write sequences. These patterns appear > repeatedly across multiple drivers with minor variations, creating > code duplication and maintenance overhead. > > Implement dw_pcie_clear_and_set_dword() helper to encapsulate atomic > register modification. The function reads the current register value, > clears specified bits, sets new bits, and writes back the result in > a single operation. This abstraction hides bitwise manipulation details > while ensuring consistent behavior across all usage sites. > > Centralizing this logic reduces future maintenance effort when modifying > register access patterns and minimizes the risk of implementation > divergence between drivers. > > Signed-off-by: Hans Zhang <18255117159@xxxxxxx> No cover-letter? Usually for things like this, it is nice to see the diffstat, which is usually part of the cover-letter. Kind regards, Niklas
