Hi Nicolas, On 6/12/25 9:56 PM, Nicolas Frattaroli wrote: > The era of hand-rolled HIWORD_UPDATE macros is over, at least for those > drivers that use constant masks. > > Remove this driver's very own HIWORD_UPDATE macro, and replace all > instances of it with equivalent instantiations of HWORD_UPDATE or > HWORD_UPDATE_CONST, depending on whether it's in an initializer. > > This gives us better error checking, and a centrally agreed upon > signature for this macro, to ease in code comprehension. > > Because HWORD_UPDATE/HWORD_UPDATE_CONST shifts the value to the mask > (like FIELD_PREP et al do), a lot of macro instantiations get easier to > read. > > This was tested on an RK3568 ODROID M1, as well as an RK3399 ROCKPro64. > > Signed-off-by: Nicolas Frattaroli <nicolas.frattaroli@xxxxxxxxxxxxx> This again LGTM and I could verify the RK3568 related bits on my Radxa ROCK 3A board. Reviewed-by: Cristian Ciocaltea <cristian.ciocaltea@xxxxxxxxxxxxx> Tested-by: Cristian Ciocaltea <cristian.ciocaltea@xxxxxxxxxxxxx> Cheers, Cristian
