On 6/12/25 9:56 PM, Nicolas Frattaroli wrote: > The era of hand-rolled HIWORD_UPDATE macros is over, at least for those > drivers that use constant masks. > > Replace this driver's HIWORD_UPDATE with the HWORD_UPDATE from > bitfield.h. While at it, disambiguate the write GRF write to SOC_CON7 by > splitting the definition into the individual bitflags. This is done > because HWORD_UPDATE shifts the value for us according to the mask, so > writing the mask to itself to enable two bits is no longer something > that can be done. It should also not be done, because it hides the true > meaning of those two individual bit flags. > > HDMI output with this patch has been tested on both RK3588 and RK3576. > On the former, with both present HDMI connectors. > > Signed-off-by: Nicolas Frattaroli <nicolas.frattaroli@xxxxxxxxxxxxx> This looks good and works fine on Radxa ROCK 5B (RK3588). Will also verify on RK3576 as soon as I get a board (expected next week). Reviewed-by: Cristian Ciocaltea <cristian.ciocaltea@xxxxxxxxxxxxx> Tested-by: Cristian Ciocaltea <cristian.ciocaltea@xxxxxxxxxxxxx>
