On Thu, Jun 12, 2025 at 11:51:56AM -0400, Frank Li wrote:
> On Thu, Jun 12, 2025 at 08:16:03PM +0530, Manivannan Sadhasivam wrote:
> > On Thu, Mar 13, 2025 at 11:38:46AM -0400, Frank Li wrote:
> > > If the parent 'ranges' property in DT correctly describes the address
> > > translation, the cpu_addr_fixup() callback is not needed. Print a warning
> > > message to inform users to correct their DTB files and prepare to remove
> > > cpu_addr_fixup().
> > >
> >
> > This patch seem to have dropped, but I do see a value in printing the warning to
> > encourage developers/users to fix the DTB in some way. Since we fixed the driver
> > to parse the DT 'ranges' properly, the presence of cpu_addr_fixup() callback
> > indicates that the translation is not properly described in DT. So DT has to be
> > fixed.
>
> This patch already in mainline with Bjorn's fine tuned at when merge.
>
> fixup = pci->ops ? pci->ops->cpu_addr_fixup : NULL;
> if (fixup) {
> fixup_addr = fixup(pci, cpu_phys_addr);
> if (reg_addr == fixup_addr) {
> dev_info(dev, "%s reg[%d] %#010llx == %#010llx == fixup(cpu %#010llx); %ps is redundant with this devicetree\n",
> reg_name, index, reg_addr, fixup_addr,
> (unsigned long long) cpu_phys_addr, fixup);
> } else {
> dev_warn(dev, "%s reg[%d] %#010llx != %#010llx == fixup(cpu %#010llx); devicetree is broken\n",
> reg_name, index, reg_addr, fixup_addr,
> (unsigned long long) cpu_phys_addr);
> reg_addr = fixup_addr;
> }
>
> return cpu_phys_addr - reg_addr;
> }
>
> I have not seen this "dev_warn(pci->dev, "cpu_addr_fixup() usage detected. Please fix your DTB!\n");"
>
This patch is supposed to add this warning and nothing else.
- Mani
--
மணிவண்ணன் சதாசிவம்
