Re: [PATCH 1/2] dt-bindings: PCI: brcm,stb-pcie: Add num-lanes property

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 6/5/25 15:36, Rob Herring wrote:
On Tue, Jun 03, 2025 at 10:17:26AM -0700, Florian Fainelli wrote:
On 6/3/25 10:16, Jim Quinlan wrote:
On Tue, Jun 3, 2025 at 12:24 PM Florian Fainelli
<florian.fainelli@xxxxxxxxxxxx> wrote:

On 5/30/25 16:32, Florian Fainelli wrote:
On 5/30/25 15:40, Jim Quinlan wrote:
Add optional num-lanes property Broadcom STB PCIe host controllers.

Signed-off-by: Jim Quinlan <james.quinlan@xxxxxxxxxxxx>

Reviewed-by: Florian Fainelli <florian.fainelli@xxxxxxxxxxxx>

Sorry I take that back, I think this should be:

num-lanes:
     enum: [ 1, 2, 4 ]

We are basically documenting the allowed values, not specifying that we
can repeat the num-lames property between 1 and 4 times.

Are you confused with maxItems?

Yes I am.



num-lanes is already defined as

      enum: [ 1, 2, 4, 8, 16, 32 ]

Right, but then we need to re-define it with our own specific constraints,
still, don't we?

It is correct as-is.

Thanks!
--
Florian




[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux