On Tue, Jun 03, 2025 at 10:17:26AM -0700, Florian Fainelli wrote: > On 6/3/25 10:16, Jim Quinlan wrote: > > On Tue, Jun 3, 2025 at 12:24 PM Florian Fainelli > > <florian.fainelli@xxxxxxxxxxxx> wrote: > > > > > > On 5/30/25 16:32, Florian Fainelli wrote: > > > > On 5/30/25 15:40, Jim Quinlan wrote: > > > > > Add optional num-lanes property Broadcom STB PCIe host controllers. > > > > > > > > > > Signed-off-by: Jim Quinlan <james.quinlan@xxxxxxxxxxxx> > > > > > > > > Reviewed-by: Florian Fainelli <florian.fainelli@xxxxxxxxxxxx> > > > > > > Sorry I take that back, I think this should be: > > > > > > num-lanes: > > > enum: [ 1, 2, 4 ] > > > > > > We are basically documenting the allowed values, not specifying that we > > > can repeat the num-lames property between 1 and 4 times. Are you confused with maxItems? > > > > num-lanes is already defined as > > > > enum: [ 1, 2, 4, 8, 16, 32 ] > > Right, but then we need to re-define it with our own specific constraints, > still, don't we? It is correct as-is. Rob