On 5/7/2025 1:10 PM, Krzysztof Kozlowski wrote:
On Wed, May 07, 2025 at 11:10:15AM GMT, Ziyue Zhang wrote:
Add compatible for qcs8300 platform, with sa8775p as the fallback.
Signed-off-by: Ziyue Zhang <quic_ziyuzhan@xxxxxxxxxxx>
---
.../bindings/pci/qcom,pcie-sa8775p.yaml | 26 ++++++++++++++-----
1 file changed, 19 insertions(+), 7 deletions(-)
diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie-sa8775p.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie-sa8775p.yaml
index efde49d1bef8..154bb60be402 100644
--- a/Documentation/devicetree/bindings/pci/qcom,pcie-sa8775p.yaml
+++ b/Documentation/devicetree/bindings/pci/qcom,pcie-sa8775p.yaml
@@ -16,7 +16,12 @@ description:
properties:
compatible:
- const: qcom,pcie-sa8775p
+ oneOf:
+ - const: qcom,pcie-sa8775p
+ - items:
+ - enum:
+ - qcom,pcie-qcs8300
+ - const: qcom,pcie-sa8775p
reg:
minItems: 6
@@ -45,7 +50,7 @@ properties:
interrupts:
minItems: 8
- maxItems: 8
+ maxItems: 9
I don't understand why this is flexible for sa8775p. I assume this
wasn't tested or finished, just like your previous patch suggested.
Please send complete bindings once you finish them or explain what
exactly changed in the meantime.
Best regards,
Krzysztof
Hi Krzysztof
Global interrupt is optional in the PCIe driver. It is not present in
the SA8775p PCIe device tree node, but it is required for the QCS8300
I did the DTBs and yaml checks before pushing this patch. This is how
I became aware that `maxItem` needed to be changed to 9.
BRs
Ziyue
