On Wed, 2025-04-23 at 18:54 +0800, Hans Zhang wrote: > The PCIE_CLIENT_GENERAL_DEBUG register offset is defined but never > used in the driver. Its presence adds noise to the register map and > may mislead future developers. > > Remove this redundant definition to keep the register list minimal > and aligned with actual hardware usage. > > Signed-off-by: Hans Zhang <18255117159@xxxxxxx> > Reviewed-by: Niklas Cassel <cassel@xxxxxxxxxx> > --- > drivers/pci/controller/dwc/pcie-dw-rockchip.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/pci/controller/dwc/pcie-dw-rockchip.c > b/drivers/pci/controller/dwc/pcie-dw-rockchip.c > index 0e0c09bafd63..fd5827bbfae3 100644 > --- a/drivers/pci/controller/dwc/pcie-dw-rockchip.c > +++ b/drivers/pci/controller/dwc/pcie-dw-rockchip.c > @@ -54,7 +54,6 @@ > #define PCIE_CLIENT_GENERAL_CONTROL 0x0 > #define PCIE_CLIENT_INTR_STATUS_LEGACY 0x8 > #define PCIE_CLIENT_INTR_MASK_LEGACY 0x1c > -#define PCIE_CLIENT_GENERAL_DEBUG 0x104 > #define PCIE_CLIENT_HOT_RESET_CTRL 0x180 > #define PCIE_CLIENT_LTSSM_STATUS 0x300 > #define PCIE_LTSSM_ENABLE_ENHANCE BIT(4) Reviewed-by: Wilfred Mallawa <wilfred.mallawa@xxxxxxx>
