On Wed, Apr 23, 2025 at 11:32:11PM +0800, Hans Zhang wrote: > 1. PCI: dw-rockchip: Remove unused PCIE_CLIENT_GENERAL_DEBUG > 2. PCI: dw-rockchip: Reorganize register and bitfield definitions > 3. PCI: dw-rockchip: Unify link status checks with FIELD_GET > > --- > Changes for v3: > - Delete the redundant Spaces in the comments of patch 2/3. > > Changes for v2: > - Add register annotations to enhance readability. > - Use macro definitions instead of magic numbers. > > https://patchwork.kernel.org/project/linux-pci/patch/20250416151926.140202-1-18255117159@xxxxxxx/ > > Bjorn Helgaas: > These would be material for a separate patch: > > - The #defines for register offsets and bits are kind of a mess, > e.g., PCIE_SMLH_LINKUP, PCIE_RDLH_LINKUP, PCIE_LINKUP, > PCIE_L0S_ENTRY, and PCIE_LTSSM_STATUS_MASK are in > PCIE_CLIENT_LTSSM_STATUS, but you couldn't tell that from the > names, and they're not even defined together. > > - Same for PCIE_RDLH_LINK_UP_CHGED, PCIE_LINK_REQ_RST_NOT_INT, > PCIE_RDLH_LINK_UP_CHGED, which are in PCIE_CLIENT_INTR_STATUS_MISC. > > - PCIE_LTSSM_ENABLE_ENHANCE is apparently in PCIE_CLIENT_HOT_RESET_CTRL? > Sure wouldn't guess that from the names or the order of #defines. > > - PCIE_CLIENT_GENERAL_DEBUG isn't used at all. > > - Submissions based on the following v5 patches: > https://patchwork.kernel.org/project/linux-pci/patch/1744850111-236269-1-git-send-email-shawn.lin@xxxxxxxxxxxxxx/ > https://patchwork.kernel.org/project/linux-pci/patch/1744850111-236269-2-git-send-email-shawn.lin@xxxxxxxxxxxxxx/ > https://patchwork.kernel.org/project/linux-pci/patch/1744850111-236269-3-git-send-email-shawn.lin@xxxxxxxxxxxxxx/ > https://patchwork.kernel.org/project/linux-pci/patch/1744940759-23823-1-git-send-email-shawn.lin@xxxxxxxxxxxxxx/ Because of *this* dependency, I couldn't apply this series. I'd suggest to respin this series avoiding the above mentioned patch and just rebase on top of controller/dw-rockchip branch: https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git/log/?h=controller/dw-rockchip - Mani -- மணிவண்ணன் சதாசிவம்
