On Tue, Apr 01, 2025 at 10:17:01AM +0100, Marc Zyngier wrote: > From: Janne Grunau <j@xxxxxxxxxx> > > Iterating over disabled ports results in of_irq_parse_raw() parsing > the wrong "interrupt-map" entries, as it takes the status of the node 'as it doesn't take account'? > into account. > > This became apparent after disabling unused PCIe ports in the Apple > Silicon device trees instead of deleting them. > > Switching from for_each_child_of_node() to for_each_available_child_of_node() > solves this issue. > > Link: https://lore.kernel.org/asahi/20230214-apple_dts_pcie_disable_unused-v1-0-5ea0d3ddcde3@xxxxxxxxxx/ > Link: https://lore.kernel.org/asahi/1ea2107a-bb86-8c22-0bbc-82c453ab08ce@xxxxxxxxxx/ > Fixes: 1e33888fbe44 ("PCI: apple: Add initial hardware bring-up") > Fixes: a0189fdfb73d ("arm64: dts: apple: t8103: Disable unused PCIe ports") > Cc: stable@xxxxxxxxxxxxxxx > Reviewed-by: Rob Herring (Arm) <robh@xxxxxxxxxx> > Acked-by: Alyssa Rosenzweig <alyssa@xxxxxxxxxxxxx> > Tested-by: Janne Grunau <j@xxxxxxxxxx> > Signed-off-by: Janne Grunau <j@xxxxxxxxxx> > Signed-off-by: Alyssa Rosenzweig <alyssa@xxxxxxxxxxxxx> > Signed-off-by: Marc Zyngier <maz@xxxxxxxxxx> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx> - Mani > --- > drivers/pci/controller/pcie-apple.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pci/controller/pcie-apple.c b/drivers/pci/controller/pcie-apple.c > index a7e51bc1c2fe8..842f8cee7c868 100644 > --- a/drivers/pci/controller/pcie-apple.c > +++ b/drivers/pci/controller/pcie-apple.c > @@ -755,7 +755,7 @@ static int apple_pcie_init(struct pci_config_window *cfg) > if (ret) > return ret; > > - for_each_child_of_node(dev->of_node, of_port) { > + for_each_available_child_of_node(dev->of_node, of_port) { > ret = apple_pcie_setup_port(pcie, of_port); > if (ret) { > dev_err(pcie->dev, "Port %pOF setup fail: %d\n", of_port, ret); > -- > 2.39.2 > -- மணிவண்ணன் சதாசிவம்
