On Tue, Aug 12, 2025 at 10:11:21AM +0800, Scott Guo wrote: > > > > By the way: > > I propose to refine the goto chain by using additional labels like “e_inval” and “e_nomem” > > so that another bit of exception handling code can be shared at the end > > of this function implementation. > > https://elixir.bootlin.com/linux/v6.16/source/fs/squashfs/super.c#L434-L466 > Will have a look into that, but maybe fix the current issue first.> Please, don't introduce more of those e_inval, e_nomem labels. regards, dan carpenter