> If sb_min_blocksize returns 0, -EINVAL was returned without freeing > sb->s_fs_info, causing mem leak. memory? How do you think about to append parentheses to the function name (in the summary phrase)? > Fix it by goto failed_mount. By the way: I propose to refine the goto chain by using additional labels like “e_inval” and “e_nomem” so that another bit of exception handling code can be shared at the end of this function implementation. https://elixir.bootlin.com/linux/v6.16/source/fs/squashfs/super.c#L434-L466 Regards, Markus