On 04/09/2025 08:37, Yulin Lu wrote: > Add document for the SATA AHCI controller on the EIC7700 SoC platform, Subject: drop "for", wrong grammar. "Document" is a verb. > including descriptions of its hardware configurations. > > Signed-off-by: Yulin Lu <luyulin@xxxxxxxxxxxxxxxxxx> ... > + > +maintainers: > + - Yulin Lu <luyulin@xxxxxxxxxxxxxxxxxx> > + - Huan He <hehuan1@xxxxxxxxxxxxxxxxxx> > + > +description: > + This document defines device tree bindings for the Synopsys DWC Describe the hardware, not the document. Entire line is completely redundant. > + implementation of the AHCI SATA controller found in Eswin's > + Eic7700 SoC platform. > + ... > + clock-names: > + items: > + - const: pclk > + - const: aclk > + > + resets: > + maxItems: 1 > + > + reset-names: > + const: arst > + > + ports-implemented: > + const: 1 I do not see how you addressed request about firmware. Nothing changed here, no explanation in the commit msg. Best regards, Krzysztof
