Re: [PATCH 10/10] ata: libata_eh: Add debug messages to ata_eh_link_set_lpm()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 6/30/25 6:11 PM, Niklas Cassel wrote:

>> To facilitate field debugging of link power management related issues,
>> add a debug message to ata_eh_link_set_lpm() to easily track LPM policy
>> changes done from EH context, that is, during device scan and
>> revalidation, error handling, and when a policy change is issued through
>> a host sysfs link_power_management_policy attribute.
>>
>> Signed-off-by: Damien Le Moal <dlemoal@xxxxxxxxxx>
>> ---
>>  drivers/ata/libata-eh.c | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/ata/libata-eh.c b/drivers/ata/libata-eh.c
>> index 7f5d13f9ca73..7134a4ff6535 100644
>> --- a/drivers/ata/libata-eh.c
>> +++ b/drivers/ata/libata-eh.c
>> @@ -2140,6 +2140,9 @@ static int ata_eh_link_set_lpm(struct ata_link *link,
>>  	if (WARN_ON_ONCE(policy == ATA_LPM_UNKNOWN))
>>  		return 0;
>>  
>> +	ata_link_dbg(link, "Set LPM policy: %d -> %d\n",
>> +		     old_policy, policy);
> 
> Nit: This is smaller than 80 columns, so it can be one line.

   The new checkpatch limit is 100 columns anyway... :-)

> Reviewed-by: Niklas Cassel <cassel@xxxxxxxxxx>

MBR, Sergey





[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux