On Mon, Jun 30, 2025 at 03:26:37PM +0900, Damien Le Moal wrote: > To facilitate field debugging of link power management related issues, > add a debug message to ata_eh_link_set_lpm() to easily track LPM policy > changes done from EH context, that is, during device scan and > revalidation, error handling, and when a policy change is issued through > a host sysfs link_power_management_policy attribute. > > Signed-off-by: Damien Le Moal <dlemoal@xxxxxxxxxx> > --- > drivers/ata/libata-eh.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/ata/libata-eh.c b/drivers/ata/libata-eh.c > index 7f5d13f9ca73..7134a4ff6535 100644 > --- a/drivers/ata/libata-eh.c > +++ b/drivers/ata/libata-eh.c > @@ -2140,6 +2140,9 @@ static int ata_eh_link_set_lpm(struct ata_link *link, > if (WARN_ON_ONCE(policy == ATA_LPM_UNKNOWN)) > return 0; > > + ata_link_dbg(link, "Set LPM policy: %d -> %d\n", > + old_policy, policy); Nit: This is smaller than 80 columns, so it can be one line. Reviewed-by: Niklas Cassel <cassel@xxxxxxxxxx>