> is OK only if all updates of that thing are externally serialized. > If they are, we don't need atomic; if they are not, this separation > of decrement and test is racy. Agreed with this too. Vport creation and deletion is serialized, so we do not need to declare debugfs_vport_count as atomic. At this point, cleaning up the lpfc_debugfs_terminate routine may be a little more involved. If it’s alright with you, Broadcom will take up the responsibility to clean up the lpfc_debugfs_terminate routine during our next driver version update, and we will of course state your authorship in that particular clean up patch. Regarding this thread’s enum selector patch, I can provide the signed off by after we see that the enum declaration is moved to lpfc_debugfs.h. Regards, Justin
