> Sure, but I'd rather do that as a followup. Yeup, that’s fine. > Speaking of other fun followups > in the same area: no point storing most of those dentries; debugfs_remove() > takes the entire subtree out, no need to remove them one-by-one and that > was the only use they were left... Something along the lines of > diff below: Very cool, thanks! We’ll take that diff too (: Also, may we actually move this enum declaration to lpfc_debugfs.h instead of lpfc_debugfs.c? enum { writeGuard = 1, writeApp, writeRef, readGuard, readApp, readRef, InjErrLBA, InjErrNPortID, InjErrWWPN, };