Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote: > Frankly, looking at that stuff... I wonder if we should add > vfs_parse_fs_qstr() for "comes with length" variant and lose the length > argument of vfs_parse_fs_string(). Um - why use a qstr? Does using a qstr actually gain anything much? Why not just, say: extern int vfs_parse_fs_str_len(struct fs_context *fc, const char *key, const char *value, size_t v_size); static inline int vfs_parse_fs_string(struct fs_context *fc, const char *key, const char *value) { return vfs_parse_fs_str_len(fc, key, value, value ? strlen(value) : 0); } Is any arch other than i386 limited to fewer than four register arguments? David