On Sat, 28 Jun 2025 at 00:58, Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote: > > Frankly, looking at that stuff... I wonder if we should add > vfs_parse_fs_qstr() for "comes with length" variant and lose the length > argument of vfs_parse_fs_string(). Yeah, I had had the same reaction that the whole "str,len" thing could be a qstr. So no objections. > Yes, it's a flagday change. Yes, not optimal, but there aren't that many call-sites, and as you say, anything that gets messed up (due to stable backports or whatever) will be caught by the compiler anyway. Linus