Re: [RFC] vfs_parse_fs_string() calling conventions change (was Re: [PATCH v2 17/35] sanitize handling of long-term internal mounts)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, 28 Jun 2025 at 00:58, Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote:
>
> Frankly, looking at that stuff...  I wonder if we should add
> vfs_parse_fs_qstr() for "comes with length" variant and lose the length
> argument of vfs_parse_fs_string().

Yeah, I had had the same reaction that the whole "str,len" thing could
be a qstr.

So no objections.

> Yes, it's a flagday change.

Yes, not optimal, but there aren't that many call-sites, and as you
say, anything that gets messed up (due to stable backports or
whatever) will be caught by the compiler anyway.

            Linus




[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [NTFS 3]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [NTFS 3]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux